Update library-redis7.0.yaml #199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vulpoi Maria-Diana <[email protected]>
craciunoiuc
reviewed
May 20, 2025
Comment on lines
+89
to
+118
| run-remote: | ||
| name: Test redis:7.0 (Remote OCI) | ||
| needs: [build, push] | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Login to OCI registry | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: index.unikraft.io | ||
| username: ${{ secrets.REG_USERNAME }} | ||
| password: ${{ secrets.REG_TOKEN }} | ||
|
|
||
| - name: Pull, run, validate and cleanup unikernel | ||
| run: | | ||
| set -euo pipefail | ||
| echo "Pull and start redis:7.0 unikernel" | ||
| IMAGE=index.unikraft.io/unikraft.org/redis:7.0 | ||
| docker pull "$IMAGE" | ||
| CONTAINER_ID=$(docker run --rm -d "$IMAGE") | ||
| echo "Wait and validate container startup" | ||
| sleep 5 | ||
| if ! docker ps --filter "id=$CONTAINER_ID" --format '{{.ID}}' | grep -q .; then | ||
| echo "ERROR: redis:7.0 unikernel is not running" >&2 | ||
| docker logs "$CONTAINER_ID" >&2 || true | ||
| docker stop "$CONTAINER_ID" || true | ||
| exit 1 | ||
| fi | ||
| echo "redis:7.0 unikernel started successfully" | ||
| echo "Cleanup container" | ||
| docker stop "$CONTAINER_ID" || true |
Member
There was a problem hiding this comment.
Please remove the run-remote job from all PRs
craciunoiuc
reviewed
May 20, 2025
Comment on lines
+128
to
+132
| - name: Install kraft CLI | ||
| run: | | ||
| echo "deb [trusted=yes] https://deb.pkg.kraftkit.sh/ /" | sudo tee /etc/apt/sources.list.d/kraftkit.list | ||
| sudo apt-get update | ||
| sudo apt-get install -y kraftkit |
Member
There was a problem hiding this comment.
You can use the kraftkit github action so there is no need to install, like we discussed
https://github.com/marketplace/actions/build-unikernel-images-with-unikraft#use-in-github-actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds GitHub Actions CI support for the Unikraft library package:
redis:7.0.Each workflow includes:
✅ run-local: Builds and runs the unikernel locally via QEMU
⚠️ push: Prepares OCI images for publishing (requires registry credentials)
✅ build: Matrix builds for QEMU and Firecracker (x86_64)
🕒 schedule: Runs the workflow daily via cron
Test logic performs functional checks such as:
kraft buildkraft runThis setup improves test coverage and CI reliability by ensuring that:
redis:7.0builds cleanly for both platformsNote
pushstep requiresREG_USERNAMEandREG_TOKENsecretsto be configured in the repository in order to push OCI images to
index.unikraft.io.Only local tests were verified during development.
Checklist
redis:7.0librarygit commit -s)